themesberg / themesberg/flowbite

Button border missing for default dark button in dark mode?

Open
#791 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
9.4k
Forks
862
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
In https://flowbite.com/docs/components/buttons/#default-button
When I switch to dark mode, the background of the third button (dark style) is very close to the dark background.
I can see that the border is set to "dark:border-gray-700", but the border is not shown because the class name "border" is missing.
image
image

Is this on purpose or is it a style mistake?

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://flowbite.com/docs/components/buttons/#default-button
  2. Click on 'Toogle dark mode'

Expected behavior
I expected the dark style button's border looks like this:
image

The same goes for the "Dark style" button in https://flowbite.com/docs/components/buttons/#button-pills

Screenshots
See above

Desktop (please complete the following information):

  • OS: Windows 10
  • Chrome
  • Version 120.0.6099.225

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Default button example at the Flowbite buttons documentation URL in the issue, then check the Button pills example for the same Dark style button. Inspect the classes used by both examples and verify the fix by toggling dark mode; done means the dark style borders are visibly rendered against the dark background.

Written by the indexing model from the issue text.

Assessment

Tech stack
html, tailwindcss
Domain
design, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
40/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.