themesberg / themesberg/flowbite

Figma File - Layer colors in Figma component instances fail to maintain persist override

Open
#556 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
9.4k
Forks
862
PR merge metrics
No merged PRs in 30d

Description

Bug Description

Layer colors in Figma component instances fail to maintain persist override.

Reproduction

If we take the button component for example, and drag an instance onto the canvas
image

And then try to override left icon
image

Notice how it looses the white color defined in the Button component and displays the color of the new icon. This makes the component partially useless as a DRY component since this color would have to be updated in each instance that uses a different icon.

The reason for this is that Figma uses the layer name to manage inheritance. And the icon layers in Flowbite are all unique. So They cannot inherit any values, like color.

Expected Behavior

Property overrides to component instances should be inherited.

Solution

One way to fix this is to normalize the names of the icons layers. So in the case of the button they should be something like "Left Button" and "Right Button" rather than the unique name of the icon itself.

Such a fix (or any other) should be implemented by FlowBite for obvious reasons.

Environment

  • MacOS
  • MBP M1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by inspecting the Figma button component and its icon layer names, then verify that overriding an icon preserves the component's layer color; done means the override persists across component instances.

Written by the indexing model from the issue text.

Assessment

Tech stack
figma
Domain
design
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.