themesberg / themesberg/flowbite

Missing popper arrow padding support in Popover component makes arrow ugly

Open
#555 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
HTML
Stars
9.4k
Forks
862
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Popover currently doesn't support passing arrow padding option, which is natively supported in popper 2.x

To Reproduce
If you look at https://flowbite.com/docs/components/popover/#description-popover
The arrow there only looks nice because of the ml-2 on the button icon. While providing workaround for the missing padding support, this also makes the icon appear "disconnected" as it's too far from the text

Expected behavior
Popovers should support arrow padding natively. We should not be forced to use button icon margin

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Popover component and its Popper 2.x integration; compare its current arrow configuration with Popper's native padding option. Check the linked Flowbite popover example, then verify that arrow padding can be passed without relying on the button icon's ml-2 workaround.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, tailwindcss
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.