themesberg / themesberg/flowbite
Modal component show and hide methods wrong conditional test
Open
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 9.4k
- Forks
- 862
- PR merge metrics
- No merged PRs in 30d
Description
Not a bug, it works perfectly, but not conform to the intention.
The show() method of the Modal component use
if ( this.isHidden ) (always returns true, the method exists)
instead of
if ( this.isHidden() ) or if ( this._isHidden )
Same for the hide() method with :
if ( this.isVisible ) (always returns true, the method exists)
instead of
if ( this.isVisible() ) or if ( ! this._isHidden )
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the Modal component and inspect its show() and hide() methods. Check that each conditional tests the component's hidden or visible state as described, then verify that the methods still show and hide the modal correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, tailwindcss
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100