themesberg / themesberg/flowbite

Modals going full screen at smaller widths

Open
#301 2 comments 0 reactions 1 assignee View on GitHub

@zoltanszogyenyi is already working on this.

Since Oct 31, 2022.

enhancement v1.6.3
Dominant language
HTML
Stars
9.4k
Forks
862
PR merge metrics
No merged PRs in 30d

Description

Its possible this is not a bug, but an intended behavior, though I don't know why it would be intended.

Modals carry this styling

<div class="relative p-4 w-full max-w-2xl h-full md:h-auto">

This means modals at mobile widths are defaulting to full height, which in most cases looks off, or at least is not a behavior I would prefer as default. Ideally this can be passed as a prop, left default for anyone currently using it but otherwise could be disabled so that h-auto work across all screen sizes.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.