themesberg / themesberg/flowbite
Modal is closed when click didn't initiate outside of content
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 9.4k
- Forks
- 862
- PR merge metrics
- No merged PRs in 30d
Description
When you click in the modal and release the click outside of it, the modal is still closed. That happend quite often when you have small modal and you go fast to select text.
They are multiple framework that suffer the same issue:
https://stackoverflow.com/questions/55732804/modal-is-closed-when-cursor-is-released-outside-the-modal-after-chrome-update-a
https://stackoverflow.com/questions/56633589/prevent-modal-from-closing-when-click-didnt-initiate-outside-of-content
sandbox : https://plnkr.co/edit/mxDLAdnrQ4p0KKyw?p=info
Expected behavior
When you click inside the modal and release the click outiside, the modal shouldn't close.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the behavior in the linked Plunker sandbox and inspect the modal's outside-click handling in the Flowbite source. Verify the fix against the reported drag or text-selection interaction; done means releasing outside after a click that began inside no longer closes the modal.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, tailwindcss
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100