themesberg / themesberg/flowbite-react

Improve banner styles

Open
#961 0 comments 0 reactions 1 assignee View on GitHub

@connerdavis47 is already working on this.

Since Sep 14, 2023.

:bug: bug confirmed
Dominant language
TypeScript
Stars
2.1k
Forks
506
PR merge metrics
No merged PRs in 30d

Description

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

I've checked the banner component and I'd like to do the following changes:

  • the X icon should have even paddings (ie. px-2 py-2 or p-2 instead of px-4 py-2)
  • responsiveness issues for some of the banners (marketing cta banner, bottom banner)

The button is too large, we should make it smaller:

Screenshot 2023-09-13 at 11 04 29

The elements should span the whole width of the screen:

Screenshot 2023-09-13 at 11 04 21

--

For reference we can check out the banners from the main Flowbite Library.

Screenshot 2023-09-13 at 11 06 15 Screenshot 2023-09-13 at 11 06 10

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.