themesberg / themesberg/flowbite-react

Avatar Dot indicator does't follow figma spec

Open
#1,509 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.1k
Forks
506
PR merge metrics
No merged PRs in 30d

Description

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Steps to reproduce

  1. Go to https://storybook.flowbite-react.com/?path=/story/components-avatar--default-avatar&args=status:online;rounded:!true
  2. Set the controls as screenshot
  • rounded: true
  • size: "lg" or "xl"
  • status: one of the statuses
  • statusPosition: "top-right"
截圖 2024-11-18 下午4 28 48
  1. You can see the dot indicator with incorrect position

Current behavior

截圖 2024-11-18 下午4 32 05

Expected behavior

https://www.figma.com/design/BwJpLnMEFPsqLDaSgylB0V/flowbite-pro-figma-v2.10.0?node-id=535-231&node-type=frame&t=78Sn0Hz6cMadUTJO-0
截圖 2024-11-18 下午4 28 03

Context

The statusPosition does not change when the size changed

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Avatar component's Storybook entry at the linked default-avatar story and reproduce the top-right status position with rounded large and extra-large avatars. Compare the rendered dot with the linked Figma design and adjust the size-dependent positioning so each status remains correctly placed; verify the affected Avatar variants in Storybook.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, storybook, tailwindcss, typescript
Domain
design, frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.