themesberg / themesberg/flowbite-react
Allow to configure "aria-label" values inside components (ie. <Modal />)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 2.1k
- Forks
- 506
- PR merge metrics
- No merged PRs in 30d
Description
- I have searched the Issues to see if this bug has already been reported
- I have tested the latest version
Summary
I'm using the <Modal> component and I would like to be able to customize the close button label (aria-label attribute) for other languages appart from english. Right now, the close button label is hardcoded to Close.
I've seen that there are multiple components where the aria-label attribute is hardcoded to english, so I think it would be a good idea to make it customizable.
If you have any ideas on how to implement this, I'd be happy to help with a contribution.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with packages/ui/src/components/Modal/ModalHeader.tsx, where the close button's aria-label is hardcoded to Close. Inspect the other components mentioned in the issue for similarly hardcoded labels, then define the customization scope and verify that labels can be supplied for the Modal and any included components.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- accessibility, frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100