themesberg / themesberg/flowbite-react

"Doughnut" in Timeline.Point when the background is not bg-white dark:bg-gray-900

Open
#1,303 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
2.1k
Forks
506
PR merge metrics
No merged PRs in 30d

Description

  • I have searched the Issues to see if this bug has already been reported
  • I have tested the latest version

Steps to reproduce

Timeline.Point ring is not transparent

Current behavior

Now the ring of the timeline points is set to white and gray-900 in dark mode, there is a kind of "doughnut" surrounding the point if the background has a different color:

image

Here you will see your default theme settings in v0.7.3:

wrapper:
            'absolute -left-3 flex h-6 w-6 items-center justify-center rounded-full bg-cyan-200 ring-8 ring-white dark:bg-cyan-900 dark:ring-gray-900',

Expected behavior

By default I would expect the ring to be ring-transparent in both modes: dark and light.

P.D: if you could also take a look to solve this would be great: https://github.com/themesberg/flowbite-react/issues/1196
Thanks in advance!!!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Timeline.Point component and inspect the default theme settings shown in the issue, especially the wrapper classes. Reproduce it with a background other than bg-white dark:bg-gray-900, then verify that the ring is transparent in both light and dark modes.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, tailwindcss, typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.