theislab / theislab/CellFlow

Output of `predict`

Open
#129 2 comments 0 reactions 1 assignee View on GitHub

@joschif is already working on this.

Since Nov 1, 2024.

bug
Dominant language
Python
Stars
159
Forks
27
PR merge metrics
No merged PRs in 30d

Description

Report

When split_covariates contains values not in perturbation_covariates or sample_covariates, e.g. zebrafish germ layers, the predict function only returns predictions for "one germ layer source".

Now the questions is what we expect it to return. I see two options:

  1. a dictionary where the condition includes the split_covariates categories, e.g. pert1_pert2_18_mesoderm
  2. we take the union of the germ layers and concatenate the result internally to only contain perturbation/sample covariates, e.g. pert1_pert2_18

In any case, I have to adapt the backend to make either of those work.

Version information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.