thefrontside / thefrontside/interactors

Trim selector text by default?

Open
#25 3 comments 0 reactions 3 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
TypeScript
Stars
36
Forks
2
Avg merge
4m
Merged PRs (30d)
2

Description

Safari includes up to one newline in its innerText property for elements. Why, I'm not sure, but it ends up that you don't match your selectors on different platforms:

image showing search for selector DEFAULT, but no match because the actual selector is DEFAULT + newline

Should we trim the selector before matching against it?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.