theforeman / theforeman/puppet-puppet

CONFIG setting in /etc/default/puppetserver isn't managed

Open
#809 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Puppet
Stars
97
Forks
243
Avg merge
8h 17m
Merged PRs (30d)
1

Description

The default value for CONFIG in /etc/default/puppetserver is /etc/puppetlabs/puppetserver/conf.d.

In my setup we point server_puppetserver_dir to another directory(/mnt/data/puppetlabs/puppetserver) but the module doesn't set the value of CONFIG in /etc/default/puppetserver fie and as a result the puppetserver process fails to start correctly.

A possible fix in manifests/server/puppetserver.pp is the following:

    $confd_path = "${server_puppetserver_dir}/conf.d"
    augeas { 'puppet::server::puppetserver::config':
      lens    => 'Shellvars.lns',
      incl    => $config,
      context => "/files${config}",
      changes => "set CONFIG '\"${confd_path}\"'",
    }

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in manifests/server/puppetserver.pp and inspect how the configuration file and server_puppetserver_dir are used. Verify that the generated /etc/default/puppetserver sets CONFIG to the selected conf.d path, then confirm the puppetserver process starts correctly with a non-default directory.

Written by the indexing model from the issue text.

Assessment

Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.