theforeman / theforeman/puppet-pulpcore
Add possibility to add extra cli.toml configuration that won't be overwritten by this module
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 2
- Forks
- 36
- Avg merge
- 4h 23m
- Merged PRs (30d)
- 1
Description
This module manages both /etc/pulp/cli.toml and /root/.config/pulp/cli.toml.
This is very inconvenient, since I can't put my extra CLI profiles anywhere without foreman-installer overwriting them with each run.
I can store my CLI profiles in a separate file and then use --config <path_to_my_cli_config> with each CLI command, but that is still pretty inconvenient.
Should we really be managing the root user config with Puppet?
Can't we store all the options we need in /etc/pulp/cli.toml?
I am guessing the reason is:
# ls -al ~/.config/pulp/cli.toml
-rw-------. 1 root root 80 Nov 21 14:53 /root/.config/pulp/cli.toml
But if I actually look at the file, it does not actually store anything terribly secret (just the path to something secret):
# cat ~/.config/pulp/cli.toml
[cli]
cert = "/etc/foreman/client_cert.pem"
key = "/etc/foreman/client_key.pem"
On a side note: Can we have puppet-pulpcore add something like:
# This file is managed by puppet-pulpcore. Any changes may be overwritten with the next foreman-installer run.
To the cli.toml files it manages?
We already had /root/.config/pulp/cli.toml before foreman-installer came along and started overwriting it, which caused some confusion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the module resources that manage /etc/pulp/cli.toml and /root/.config/pulp/cli.toml. Review the existing nine-comment discussion before proposing a direction, since the issue presents several alternatives without a decision. Done should preserve user CLI profiles and clearly identify any configuration files that remain managed.
Written by the indexing model from the issue text.
Assessment
- Domain
- cli, devops
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100