theforeman / theforeman/foremanctl
Review dynflow-sidekiq exec command
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 27
- Forks
- 47
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 40
Description
Based on https://github.com/evgeni/talks/pull/4#discussion_r1932083989 we should review the command:
This copies the DYNFLOW_SIDEKIQ_SCRIPT (that's also set as an env var) and hardcodes the Rails environment, but do we even need to expose this in the first place? It's based on https://github.com/theforeman/foreman/blob/74ddd8851cebd21c268002e0c82a3619d2a9db66/extras/systemd/dynflow-sidekiq%40.service#L12-L20 but is it better to provide a better /usr/libexec/foreman/sidekiq-selinux wrapper script that has these defaults built in?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with roles/foreman/tasks/main.yaml around line 90 and compare it with the referenced dynflow-sidekiq@.service command and the DYNFLOW_SIDEKIQ_SCRIPT environment variable. Determine whether the command should remain exposed or use the proposed /usr/libexec/foreman/sidekiq-selinux wrapper; done means the chosen approach and its Rails environment defaults are consistently represented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rails
- Domain
- devops, infrastructure
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100