the-guild-org / the-guild-org/apollo-angular
HttpBatchLink does not include the response in the context
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.5k
- Forks
- 309
- Avg merge
- 1h 45m
- Merged PRs (30d)
- 3
Description
Describe the bug
HttpBatchLink does not include the response into the context. The HttpLink does include this information so there is a divergence between the behaviours for links that need to handle headers or other such information from the response.
To Reproduce
Steps to reproduce the behavior:
Add a simple link to observe the results from the HttpBatchLink and observe that the response does not exist in the operation context.
Expected behavior
The HttpLink and HttpBatchLink should act the same by adding the response into the context.
Environment:
- @angular/cli@20.3.15
- @angular/core@20.3.15
- @apollo/client@3.14.0
- apollo-angular@11.0.0
- graphql@16.11.0
- typescript@5.8.3
Additional context
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the HttpLink and HttpBatchLink implementations and reproduce the issue with a simple link that inspects the operation context. The fix is done when HttpBatchLink exposes the response in the context consistently with HttpLink; add or update a regression test if the relevant test location is identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, graphql, typescript
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100