the-guild-org / the-guild-org/apollo-angular

Support for Angular Signals ?

Open
#2,088 16 comments 25 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

idea
Dominant language
TypeScript
Stars
1.5k
Forks
309
Avg merge
1h 45m
Merged PRs (30d)
3

Description

Angular v17 includes a stable API for Signals. I am wondering if that might have an impact for apollo-angular or not.

So far I would say that because apollo-angular is mostly doing XHR, and that XHR must be cancellable, then we must keep using observable. And if somebody would rather work with non-cancellable signal (which does not sound like a great idea to me), then it is up to them to adapt their consuming code. So there is nothing to be done within the lib.

But I'd like to hear the thoughts of the community and see if I am maybe missing something ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the Angular Signals guide linked in the issue and reviewing how apollo-angular currently uses Observable-based, cancellable XHR. Determine whether Signals require a library change or only consumer-side adaptation; the issue is done when that scope is decided and documented.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, graphql, typescript
Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.