testng-team / testng-team/testng-asserts

Replace Assert implementation by AssertJ

Open
#15 12 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Recently, we had many issues with Assertion. See testng-team/testng#2643 testng-team/testng-asserts#14 testng-team/testng#2540

I think it could be helpful to deprecate the internal assertion API and let the user choose the library he prefers.
It will allow us to drop some annex subjects and be more focused on the test engine.

One option could be to shade AssertJ into the TestNG jar and use it as the default implementation of Assertion.

@krmahadevan WDYT?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the internal assertion API and the referenced issues testng-team/testng#2643, testng-team/testng-asserts#14, and testng-team/testng#2540. Determine whether deprecating that API and shading AssertJ into the TestNG jar is agreed scope; done would require a decided replacement strategy and compatible implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.