testing-library / testing-library/user-event

Update `14.4.3 -> 14.5.0` causes error `TS1005: ',' expected`

Open
#1,161 1 comment 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug needs assessment
Dominant language
TypeScript
Stars
2.3k
Forks
258
No merged PRs in 30d

Description

Reproduction example

https://github.com/taiga-family/maskito/pull/507
https://github.com/taiga-family/maskito/pull/518

Actual behavior

See https://github.com/taiga-family/maskito/actions/runs/6189000924/job/16802149821?pr=507

Error: node_modules/@testing-library/user-event/dist/types/clipboard/copy.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/clipboard/cut.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/clipboard/paste.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/convenience/click.d.ts(1,[15](https://github.com/taiga-family/maskito/actions/runs/6189000924/job/16802149821?pr=507#step:4:16)): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/convenience/hover.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/convenience/tab.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/dispatchEvent.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/input.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/selection/index.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/selection/modifySelectionPerMouse.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/event/selection/setSelectionPerMouse.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/index.d.ts(6,40): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/keyboard/index.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/options.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/options.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/pointer/index.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/pointer/index.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/pointer/index.d.ts(3,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/setup/directApi.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/setup/directApi.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/setup/directApi.d.ts(3,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/setup/directApi.d.ts(4,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/system/keyboard.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/system/keyboard.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/system/pointer/buttons.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/clear.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/selectOptions.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/type.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/type.d.ts(2,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utility/upload.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utils/misc/level.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utils/misc/wait.d.ts(1,15): error TS1005: ',' expected.
Error: node_modules/@testing-library/user-event/dist/types/utils/pointer/cssPointerEvents.d.ts(1,15): error TS1005: ',' expected.
Error: Process completed with exit code 2.
User-event version

14.5.0

Environment

No response

Additional context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reproduction pull requests #507 and #518 and the linked GitHub Actions job. Inspect the published @testing-library/user-event 14.5.0 declaration files named in the errors and compare the TypeScript versions used by the failing checks. Done means the update no longer produces TS1005 errors in those checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.