testing-library / testing-library/dom-testing-library

bumping dom-accessibility-api to 0.6x

Open Beginner friendly
#1,358 1 comment 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
3.3k
Forks
474
PR merge metrics
No merged PRs in 30d

Description

dom-accessibility-api has seen its description retrieval fixed a while ago but you guys still depends on ^0.5.9.

Describe alternatives you've considered:

for now I overrides the version in my package.json. But I have to explicitly depend on "@testing-library/dom"

{
  "devDependencies": {
      "@testing-library/user-event": "14.4.3",
      "@testing-library/angular": "17.3.7",
      "@testing-library/dom": "^10.4.0",
      "dom-accessibility-api": "0.6.3",
  },
  "overrides": {
      "@testing-library/dom": {
          "dom-accessibility-api": "$dom-accessibility-api"
      }
  }
}

I think it would makes sense to bump directly into your package.json

Thanks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the package manifest and dependency metadata for @testing-library/dom, then inspect how dom-accessibility-api is currently constrained. Update the dependency to the requested 0.6.x release, refresh any lockfile if present, and run the repository's test suite to verify the change.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.