testcontainers / testcontainers/testcontainers-rs

Why is `WaitStrategy` pub(crate) scope?

Open
#772 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.1k
Forks
197
PR merge metrics
No merged PRs in 30d

Description

It would be incredibly useful to be able to define custom WaitStrategy implementations. For example, checking a port is properly accessible.

It's unclear why the WaitStrategy trait is scoped to pub(crate), effectively removing this capability.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the WaitStrategy trait and its pub(crate) visibility in the repository, then inspect how existing wait strategies are defined and used. Determine the public API needed for external implementations such as port checks; done means custom implementations can be defined outside the crate without breaking existing behavior, with relevant tests passing.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.