testcontainers / testcontainers/testcontainers-python
no -v option in docker-compose down
Open
Nobody has claimed this yet.
📦 package: compose
🛟 help wanted
- Dominant language
- Python
- Stars
- 2.3k
- Forks
- 386
- Avg merge
- 4h 40m
- Merged PRs (30d)
- 1
Description
Currently DockerCompose object is stopped like this.
def stop(self):
down_cmd = self.docker_compose_command() + ['down', '-v']
subprocess.call(down_cmd, cwd=self.filepath)
The '-v' option is firmly coded - I would like to be able to choose the options for stop command. Sometimes I don't want the volumes to be removed
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the DockerCompose.stop method shown in the issue and inspect how its docker-compose command is assembled and called. Make the stop options selectable so volume removal is not mandatory, then verify that stopping can preserve volumes while retaining the current behavior when requested.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker-compose, python
- Domain
- devops
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100