testcontainers / testcontainers/testcontainers-java
Use of links between containers should be deprecated
Open
Nobody has claimed this yet.
resolution/acknowledged
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 1.9k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 9
Description
As discussed in #463, docker networks seem mature enough to use, and links are officially not recommended any more.
We'd like to deprecate use of links; off the top of my head I believe we ought to do the following things:
- Obviously, mark the container
addLinkmethod as deprecated with a clear comment - Links aren't currently documented very well, but update the docs with a clear enough description of the networking support, so that ad-hoc linking can be done easily by users
- Modify Webdriver VNC recorder sidecar container to remove use of links
- Modify Docker Compose support; can we remove use of the ambassador container now?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Docker Compose support and its ambassador container usage, then inspect the related tests and current networking behavior. Determine whether the ambassador can be removed without breaking Compose-based tests; done means links are no longer required there and the existing Compose support remains covered by passing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, docker-compose, java
- Domain
- devops, infrastructure, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100