testcontainers / testcontainers/testcontainers-java
Include docker-java-api in BOM
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 1.9k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 9
Description
docker-java-api is part of the (advanced) public API of Testcontainers and thus it seems appropriate and helpful to have it be part of the BOM.
In my use case, I wanted to override GenericContainer.containerIsStarted(), which means I have a compile time dependency on InspectContainerResponse(as it is a parameter) and thus must declare a dependency on docker-java-api.
The problem is that I need to supply a version for the dependency, but what version do I use use? The answer is that it must be the same version as used by Testcontainers, but there's no way to do it automatically, so I have to manually copy/paste the version and keep it updated whenever I update Testcontainers. If it was in the BOM, I could simply add the dependency without a version and it would always be correct.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files or tests. Start by locating the BOM definition and the existing docker-java-api dependency/version; add the artifact to managed dependencies so consumers can omit its version, then verify the BOM resolves the same version used by Testcontainers.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, java
- Domain
- build-system
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100