testcontainers / testcontainers/testcontainers-java
Testcontainers is including shaded classes of Bouncycastle
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 1.9k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 9
Description
Hi,
I've read that with version 1.11 (https://github.com/testcontainers/testcontainers-java/pull/1307) the shaded dependencies were removed. I'm using v 1.15.3 now and I still see shaded classes in org.testcontainers.shaded.org.bouncycastle. While this hasn't caused direct issues for me (yet), autocomplete still suggests those classes before the ones that I directly include as dependencies in my project.
I know this is a debatable subject, but if the initial reason for shading (netty) went away in May 2019, then these classes really should not be in here anymore.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting the published 1.15.3 artifact for org.testcontainers.shaded.org.bouncycastle and trace the dependency-shading configuration that produces it. Confirm the project’s existing tests or artifact checks, and consider the work complete when the unwanted shaded classes are no longer packaged without breaking the library’s dependencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100