testcontainers / testcontainers/testcontainers-java
There might be some duplication in `HostPortWaitStrategy`
Open
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 1.9k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 9
Description
When being used with docker-compose module, withExposedService adds a distinct HostPortWaitStrategy for every port. At the same time HostPortWaitStrategy uses getLivenessCheckPorts() to get all ports to wait thus making extra duplication and mess.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading HostPortWaitStrategy and the docker-compose handling of withExposedService, including getLivenessCheckPorts(). Trace how strategies and ports are registered, then determine the intended single source of waiting behavior and verify that each exposed service still waits correctly without duplicate strategies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, docker-compose, java
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100