testcontainers / testcontainers/testcontainers-java
GenericContainer#isHealthy throws NPE if the healthcheck is not set
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 8.7k
- Forks
- 1.9k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 9
Description
Looks like health state is no longer part of the docker inspect response (api v1.40).
Looks like docker-java is mistakenly returning it in the response so we can't rely on that:
https://github.com/docker-java/docker-java/blob/066f268fa4f88687a9e7a41ca5eeaa85d63d8455/docker-java-api/src/main/java/com/github/dockerjava/api/command/InspectContainerResponse.java#L336-L340
Reproducer: https://github.com/testcontainers/testcontainers-java/pull/2204
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with GenericContainer#isHealthy and the Docker inspect response handling described in the issue, then run or inspect the reproducer in pull request #2204. Compare behavior when no healthcheck is configured with the Docker API v1.40 response. Done means GenericContainer#isHealthy no longer throws a NullPointerException in that case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, java
- Domain
- infrastructure, testing
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100