testcontainers / testcontainers/testcontainers-go

[Enhancement]: Improve model pull progress display with a progress bar instead of logs

Open
#3,280 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Go
Stars
5k
Forks
637
Avg merge
2d 12h
Merged PRs (30d)
26

Description

Proposal

This issue is created to address the TODO comment found in the (c *Client) PullModel function, from @mdelapenya

// TODO: use a progressbar instead of multiple line output.
Why is it needed?
  • Currently, pulling a model floods the terminal with raw log output. This makes it difficult for users to track the actual download progress and results in a poor user experience.
Proposed Solution

Replace the current line-by-line logging with a progress bar.
This can be achieved by:

  • Parsing the JSON stream from the response body to get the download status.
  • Using a terminal progress bar library (e.g., github.com/schollz/progressbar/v3) to visually display the progress based on the parsed data.

I'd appreciate any feedback on this proposal. If this sounds like a good idea, I'd be happy to open a Pull Request to implement it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in modules/dockermodelrunner/internal/sdk/client/pull.go at the PullModel function and review the TODO plus its current response handling. Inspect the JSON stream fields that represent download status and evaluate how a terminal progress bar library would consume them. Done means model pulls show progress visually instead of flooding the terminal with line-by-line logs.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.