testcontainers / testcontainers/testcontainers-go

Allow to customise reaper image, or use fully qualified image name

Open
#3,262 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5k
Forks
637
Avg merge
2d 12h
Merged PRs (30d)
26

Description

https://github.com/testcontainers/testcontainers-go/blob/c100f88ec720a6fc4e8ed984e3f4de5954a65e6e/internal/config/config.go#L14

I tried using testcontainers on a system with Podman, and I can't spawn it due to the line above. With Podman on many OSs, the testcontainers/ryuk:0.12.0 doesn't automatically resolve to docker.io/testcontainers/ryuk:0.12.0. I can't configure testcontainers to use docker.io/testcontainers/ryuk:0.12.0, because the value is an internal constant.

To solve this, I see two options:

  1. Simply change the constant to docker.io/testcontainers/ryuk:0.12.0, which would work on all the systems, even on those that don't default to Docker Hub as the default registry.
  2. Allow for customization of the reaper image.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in internal/config/config.go at line 14 and trace where the reaper image is consumed. Compare the requested fully qualified default and configurable-image approaches, then verify the chosen behavior with Podman and Docker; done means the reaper image resolves successfully in both environments.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, go
Domain
devtools, testing-qa
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.