testcontainers / testcontainers/testcontainers-dotnet
[Enhancement]: Make `ingest.geoip.downloader.enabled` environment of elastic container optional
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 4.4k
- Forks
- 357
- Avg merge
- 14h 42m
- Merged PRs (30d)
- 16
Description
Problem
Not all elastic images are compatible with the ingest.geoip.downloader.enabled environment. We use a custom image which produces the following error
unknown setting [ingest.geoip.downloader.enabled] please check that any required plugins are installed, or check the breaking changes documentation for removed settings
Solution
Add an option in the constructor of ElasticsearchContainer, or a separate method, to prevent setting the ingest.geoip.downloader.enabled environment.
Benefit
A broader range of custom elastic images will be supported.
Alternatives
For now, we use the following workaround
.WithEnvironment("ingest.geoip.downloader.enabled", "")
Would you like to help contributing this enhancement?
Yes
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the ElasticsearchContainer entry point and locate where the ingest.geoip.downloader.enabled environment is configured. Check how constructor or separate-method options are exposed, then verify that custom images can omit the setting while existing behavior remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, docker, elasticsearch
- Domain
- testing
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100