tensorflow / tensorflow/tflite-support
Migrate away from assertDeepAlmostEqual
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 441
- Forks
- 146
- PR merge metrics
- No merged PRs in 30d
Description
The reason to use tf.test, is to be able to use https://www.tensorflow.org/api_docs/python/tf/test/TestCase#assertProtoEquals instead of our own implementation.
@kinaryml
Could you investigate if you can migrate away from using assertDeepAlmostEqual?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading tensorflow_lite_support/python/test/base_test.py, especially the custom assertDeepAlmostEqual implementation, then search the repository for its usages. Compare those tests with tf.test.TestCase and assertProtoEquals; done means the relevant usages no longer depend on the custom helper and the affected tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, tensorflow
- Domain
- testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100