tensorflow / tensorflow/tflite-micro

Unhandled overflow in int8 SVDF evaluation

Open
#2,721 4 comments 1 reaction 3 assignees View on GitHub

@ddavis-2015 is already working on this.

Since Feb 17, 2025.

type:bug
Dominant language
C++
Stars
3.1k
Forks
1.1k
Avg merge
1d 5h
Merged PRs (30d)
43

Description

When calculating the values to be inserted in the SVDF operator’s activation state in the svdf_common.cc file, there seems to be an error while handling overflow.
In line 111 the value for the dot_prod variable is limited to the interval of valid int8 values, [-128, 127]. But then, in line 115, the activation state’s zero point is added to dot_prod, which may lead to an unhandled overflow.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.