Incorrect trimming lengths for RoundRobinTrimmer
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 1.3k
- Forks
- 379
- Avg merge
- 3h 30m
- Merged PRs (30d)
- 8
Description
For at least some inputs, it looks like the RoundRobinTrimmer is incorrectly trimming input sequences.
This colab shows the bug. https://colab.sandbox.google.com/gist/mattdangerw/00ae1557aa6a3901fecaf5bc6a6e1b1d/trimming-bug.ipynb
Running RoundRobinTrimmer(8) followed by combine_segments on two batches of segments, you should have a maximum row length of 11 (8 + 3 start and end tokens). But the above colab will produce row lengths of [13, 12, 11].
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported case from the linked trimming-bug.ipynb, using RoundRobinTrimmer(8) followed by combine_segments on the two batches of segments. Trace the trimming and combination entry points to determine why the resulting lengths are [13, 12, 11]; done means the maximum row length is 11, including the three start and end tokens.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100