tensorflow / tensorflow/tensorboard

The example plugin not loading on Safari

Open
#6,059 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7.2k
Forks
1.7k
Avg merge
4d 22h
Merged PRs (30d)
1

Description

Hi Tensorboard team,

After built the example plugin (https://github.com/tensorflow/tensorboard/tree/master/tensorboard/examples/plugins/example_raw_scalars), I found it can't be loaded on Safari. However, it does work on Chrome. The error message shows like this:

W1117 22:38:41.826974 13009694720 application.py:558] path /data/static/index.js not found, sending 404

Apparently it's a path issue. When I click the plugin tag on Safari, it's requesting to the wrong path. After changing this line from

es_module_path="/static/index.js"

to

es_module_path="/plugin/example_raw_scalars/static/index.js"

it works on Safari but doesn't work on Chrome because of the extra path.

I guess this issue is caused by this line of code:

module_json = json.dumps("." + module_path)

Where relative path behaves differently on Apple Webkit & Chromium. Is this a bug? Thanks.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the example_raw_scalars plugin loading issue in Safari and Chrome. Inspect tensorboard/examples/plugins/example_raw_scalars/tensorboard_plugin_example_raw_scalars/plugin.py at line 108 and tensorboard/backend/application.py at line 376, then trace the generated module path. Done means the example plugin loads correctly in both browsers without a 404 for index.js.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, python
Domain
backend, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.