tensorflow / tensorflow/tensorboard

hparams: sends 4 requests when hparams data is missing

Open
#4,970 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:frontend plugin:hparams
Dominant language
TypeScript
Stars
7.2k
Forks
1.7k
Avg merge
4d 22h
Merged PRs (30d)
1

Description

Repro steps:

  1. launch TB on an empty logdir
  2. open your favorite dev tools
  3. open the hparams dashboard
  4. notice 4 requests to /data/plugin/hparams/experiment

Description: not a bug per say but this is an inefficiency.

Cause:

  1. requestManager has a retry mechanism and # of retries are determined by the setting: https://github.com/tensorflow/tensorboard/blob/5214b0822af46de61091eca608c59ab2fd0fbdc2/tensorboard/components/tf_backend/requestManager.ts#L109
  2. hparams dashboard uses the requqestManager: https://github.com/tensorflow/tensorboard/blob/5214b0822af46de61091eca608c59ab2fd0fbdc2/tensorboard/plugins/hparams/tf_hparams_backend/tf-hparams-backend.ts#L66-L79
  3. requestManager retries on non-200: https://github.com/tensorflow/tensorboard/blob/5214b0822af46de61091eca608c59ab2fd0fbdc2/tensorboard/components/tf_backend/requestManager.ts#L244

Ideal changes:

  • we retry only when error status is status < 100 || status >= 500

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with tensorboard/components/tf_backend/requestManager.ts, especially the retry setting and non-200 handling, then inspect tensorboard/plugins/hparams/tf_hparams_backend/tf-hparams-backend.ts. Reproduce the empty-logdir case in the hparams dashboard and verify that retries occur only for statuses below 100 or at least 500, avoiding the four repeated requests.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.