tensorflow / tensorflow/tensorboard
cleanup: remove tf_web_library and tensorboard_html_binary
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
After the Polymer migration, we no longer rely on tensorboard_html_binary for building TypeScript and building the JavaScript bundle. Instead, we started to use ts_library (soon, ts_project) and rollup_binary.
we still use tensorboard_html_binary (and tf_web_library) for these things:
- inlining CSS, JS
- asset zipping (webfiles.zip)
If we inline less or if we employ jinja2, we no longer need the entire tensorboard_html_binary which forces us to depend on Java/Closure compiler/etc... which we can easily get rid of.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the remaining uses of tensorboard_html_binary and tf_web_library, then review the existing ts_library, ts_project, and rollup_binary build paths. The work is done when CSS and JavaScript inlining and webfiles.zip asset packaging no longer require those rules or their Java and Closure Compiler dependencies.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java, javascript, typescript
- Domain
- build-system, tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100