tensorflow / tensorflow/tensorboard
Safari is not handling es module loading with <base href /> as expected
Open
@stephanwlee is already working on this.
Since Jun 15, 2020.
core:frontend
stat:awaiting tensorflower
type:browser
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
Consider Stack Overflow for getting support using TensorBoard—they have
a larger community with better searchability:
https://stackoverflow.com/questions/tagged/tensorboard
Do not use this template for for setup, installation, or configuration
issues. Instead, use the “installation problem” issue template:
https://github.com/tensorflow/tensorboard/issues/new?template=installation_problem.md
To report a problem with TensorBoard itself, please fill out the
remainder of this template.
Environment information (required)
Please run diagnose_tensorboard.py (link below) in the same
environment from which you normally run TensorFlow/TensorBoard, and
paste the output here:
Diagnostics
Diagnostics output
--- check: autoidentify
INFO: diagnose_tensorboard.py version 724b56cee52e7d8eb89bbeec1f0d5ce3e38c9682
--- check: general
INFO: sys.version_info: sys.version_info(major=3, minor=7, micro=3, releaselevel='final', serial=0)
INFO: os.name: posix
INFO: os.uname(): posix.uname_result(sysname='Darwin', nodename='MacBook-Air.local', release='19.5.0', version='Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64', machine='x86_64')
INFO: sys.getwindowsversion(): N/A
--- check: package_management
INFO: has conda-meta: False
INFO: $VIRTUAL_ENV: '/Users/dhruvin/Projects/tensorboard-plugin-netron/venv'
--- check: installed_packages
INFO: installed: tensorboard==2.2.2
INFO: installed: tensorflow==2.2.0
INFO: installed: tensorflow-estimator==2.2.0
--- check: tensorboard_python_version
INFO: tensorboard.version.VERSION: '2.2.2'
--- check: tensorflow_python_version
INFO: tensorflow.__version__: '2.2.0'
INFO: tensorflow.__git_version__: 'v2.2.0-rc4-8-g2b96f3662b'
--- check: tensorboard_binary_path
INFO: which tensorboard: b'/Users/dhruvin/Projects/tensorboard-plugin-netron/venv/bin/tensorboard\n'
--- check: addrinfos
socket.has_ipv6 = True
socket.AF_UNSPEC = <AddressFamily.AF_UNSPEC: 0>
socket.SOCK_STREAM = <SocketKind.SOCK_STREAM: 1>
socket.AI_ADDRCONFIG = <AddressInfo.AI_ADDRCONFIG: 1024>
socket.AI_PASSIVE = <AddressInfo.AI_PASSIVE: 1>
Loopback flags: <AddressInfo.AI_ADDRCONFIG: 1024>
Loopback infos: [(<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('127.0.0.1', 0)), (<AddressFamily.AF_INET6: 30>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('::1', 0, 0, 0))]
Wildcard flags: <AddressInfo.AI_PASSIVE: 1>
Wildcard infos: [(<AddressFamily.AF_INET6: 30>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('::', 0, 0, 0)), (<AddressFamily.AF_INET: 2>, <SocketKind.SOCK_STREAM: 1>, 6, '', ('0.0.0.0', 0))]
--- check: readable_fqdn
INFO: socket.getfqdn(): '1.0.0.127.in-addr.arpa'
--- check: stat_tensorboardinfo
INFO: directory: /var/folders/xg/vx6b684572sg6fzbrc57k2_w0000gn/T/.tensorboard-info
INFO: os.stat(...): os.stat_result(st_mode=16895, st_ino=2958273, st_dev=16777223, st_nlink=4, st_uid=501, st_gid=20, st_size=128, st_atime=1592029645, st_mtime=1592052632, st_ctime=1592052632)
INFO: mode: 0o40777
--- check: source_trees_without_genfiles
INFO: tensorboard_roots (1): ['/Users/dhruvin/Projects/tensorboard-plugin-netron/venv/lib/python3.7/site-packages']; bad_roots (0): []
--- check: full_pip_freeze
INFO: pip freeze --all:
absl-py==0.9.0
astunparse==1.6.3
cachetools==4.1.0
certifi==2020.4.5.2
chardet==3.0.4
gast==0.3.3
google-auth==1.17.2
google-auth-oauthlib==0.4.1
google-pasta==0.2.0
grpcio==1.29.0
h5py==2.10.0
idna==2.9
importlib-metadata==1.6.1
Keras-Preprocessing==1.1.2
Markdown==3.2.2
netron==4.3.2
numpy==1.18.5
oauthlib==3.1.0
opt-einsum==3.2.1
pip==20.1.1
protobuf==3.12.2
pyasn1==0.4.8
pyasn1-modules==0.2.8
requests==2.23.0
requests-oauthlib==1.3.0
rsa==4.6
scipy==1.4.1
setuptools==47.1.1
six==1.15.0
tensorboard==2.2.2
-e git+https://github.com/dhruvin2910/tensorboard-plugin-netron.git@6d71bde8af86d52a77aa12cf96ff313a6557492a#egg=tensorboard_plugin_netron
tensorboard-plugin-wit==1.6.0.post3
tensorflow==2.2.0
tensorflow-estimator==2.2.0
termcolor==1.1.0
urllib3==1.25.9
Werkzeug==1.0.1
wheel==0.34.2
wrapt==1.12.1
zipp==3.1.0
For browser-related issues, please additionally specify:
- Browser type and version (e.g., Chrome 64.0.3282.140): Safari Version 13.1.1 (15609.2.9.1.2)
- Screenshot, if it’s a visual issue: Not a visual issue
Issue description
Please describe the bug as clearly as possible. How can we reproduce the
problem without additional resources (including external data files and
proprietary Python modules)?
Steps:
- Start TensorBoard with a plugin that uses
es_module_pathloading mode. In my case it istensorboard-plugin-netron - Open the plugin's tab in Safari.
Expectation:
- The es_module_path
/render.jsshould resolve todata/plugin/netron/render.js.
Issues:
- Safari resolves that path to
data/render.js. It seems to me that the module loader of safari ignores (or does not understand) the specified<base href="..." />.
Note:
- Other urls do use
plugin/netron/as base href for relative url resolution. The problem is only with theimport(<url>).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.