tensorflow / tensorflow/tensorboard

[DebuggerV2] debugger_types.ts should depend on tfdbg2_data_source.ts

Open
#3,376 0 comments 0 reactions 1 assignee View on GitHub

@caisq is already working on this.

Since Mar 16, 2020.

plugin:debugger
Dominant language
TypeScript
Stars
7.2k
Forks
1.7k
Avg merge
4d 22h
Merged PRs (30d)
1

Description

This is an internal cleanup / refactoring bug:

  • Currently, tfdbg2_data_source.ts imports from debugger_types.ts.
  • It should be probably be other way around, because the data source spec is more fundamental than the type definitions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.