tensorflow / tensorflow/tensorboard
Make dynamic plugin smoke test a non-test target
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
The //tensorboard/examples/plugins/example_basic:smoke_test target is
a Bazel sh_test target, but is far from hermetic: it talks to the real
PyPI network and installs the latest version of tf-nightly, which may
be broken. We should consider demoting this to a sh_binary test script
to be bazel run by CI but not run under bazel test //tensorboard/....
For example, this is what we do for testing //tensorboard/pip_package,
which is built ~hermetically (in the relevant quotient) but tested
only non-hermetically.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the //tensorboard/examples/plugins/example_basic:smoke_test target and compare it with the non-hermetic testing approach for //tensorboard/pip_package. Check how CI invokes these targets, then change the smoke test target classification so it is run explicitly rather than by bazel test //tensorboard/...; done means the dynamic plugin smoke test no longer runs in that test suite.
Written by the indexing model from the issue text.
Assessment
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100