tensorflow / tensorflow/tensorboard
'probabilities' predict_output_tensor is confusing
Open
Nobody has claimed this yet.
core:backend
stat:awaiting tensorflower
type:feature
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
I noticed in https://github.com/tensorflow/tensorboard/blob/master/tensorboard/plugins/interactive_inference/witwidget/notebook/base.py#L510
that it expects a few hard-coded tensor names for output. A few issues here:
- Could WIT just default to grabbing the first tensor in case predict_output_tensor isn't set? That will match many Keras models.
- In the case there are multiples, could we have a smarter guess? Keras Sequential will use "output_1", or "dense_1" in many cases. Not sure what estimators will do.
- Finally, if it's set incorrectly, could we have a better error message? Right now it's a black box called "probabilities"
We may want to make this a required param, too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.