tensorflow / tensorflow/tensorboard
cleanup: remove type error suppression in webcomponents-externs
Open
Nobody has claimed this yet.
type:cleanup
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
let statements in https://github.com/Polymer/polymer/blob/2.x/externs/webcomponents-externs.js causes serious type error like below:
Jul 15, 2019 8:33:41 AM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: external/org_polymer_externs/externs/webcomponents-externs.js:15: WARNING - [JSC_BLOCK_SCOPED_DECL_MULTIPLY_DECLARED_ERROR] Duplicate let / const / class / function declaration in the same scope is not allowed.
let HTMLImports = {
^^^^^^^^^^^^^^^
Jul 15, 2019 8:33:41 AM com.google.javascript.jscomp.LoggerErrorManager println
WARNING: external/org_polymer_externs/externs/webcomponents-externs.js:15: WARNING - [JSC_REDECLARED_VARIABLE_ERROR] Illegal redeclared variable: HTMLImports
let HTMLImports = {
^^^^^^^^^^^^^^^
Newer externs for (v3; internal version matches that of v3) seems to be okay.
https://github.com/Polymer/polymer/blob/master/externs/webcomponents-externs.js
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with externs/webcomponents-externs.js and compare it with the newer v3 version linked in the issue. Verify the cleanup against the reported Closure Compiler warnings; done means the extern no longer produces duplicate or illegal redeclaration errors.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- build-system
- Issue type
- Refactor
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100