tensorflow / tensorflow/tensorboard
Mesh plugin JS warnings: “'cls' is not a property of this material.”
Open
Nobody has claimed this yet.
plugin:mesh
type:bug
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
Repro steps (from current master, 0fe0413f):
- Run
//tensorboard/plugins/mesh:mesh_demoto generate test data. - Launch TensorBoard, and open the mesh plugin.
- Drag the step slider back and forth.
Each tick that the slider is dragged, a new warning will appear in the
console:
THREE.MeshStandardMaterial: 'cls' is not a property of this material. Bh @ (index):16360 Y.MeshStandardMaterial @ (index):16388 b._createMesh @ (index):29633 b._createGeometry @ (index):29629 b.updateScene
Presumably the cls key should be removed from the config objects
before they’re passed along to THREE.js.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running //tensorboard/plugins/mesh:mesh_demo, launching TensorBoard, and dragging the mesh plugin's step slider while watching the console. Trace the Mesh plugin path that creates the THREE.MeshStandardMaterial config, then verify that the cls key is not passed to THREE.js and that repeated slider changes no longer produce the warning.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- three.js, typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100