tensorflow / tensorflow/tensorboard
All external help links should open in a new tab
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
Links like “you have no data; click here for docs” should all open in a
new tab. When TensorBoard is rendered in a notebook context (either
Jupyter or Colab), if the links do not open in a new tab then they will
appear in the output frame—but most sites prevent themselves from being
included in iframes (including any documentation hosted on GitHub), so
the entire frame will fail to load an just appear as a white rectangle.
Ideally we would have some kind of lint rule or automated check to
prevent regressions here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the TensorBoard frontend for external help links, then inspect the notebook-rendering paths for Jupyter and Colab. Verify how links currently behave inside the output frame. Done means external help links open in a new tab in notebook contexts and a regression check prevents them from reverting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- jupyter, typescript
- Domain
- frontend, web-dev
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100