tensorflow / tensorflow/tensorboard

Scalar plugin download links should work in Colab

Open
#1,845 7 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

plugin:scalars stat:awaiting response type:bug
Dominant language
TypeScript
Stars
7.2k
Forks
1.7k
Avg merge
4d 22h
Merged PRs (30d)
1

Description

Currently, the scalar plugin download links use <a href download>,
where the href points to a route on the TensorBoard backend. This
works fine locally, but on Colab requests to the backend are mediated by
a service worker, and the service worker does not appear to intercept
these requests. Consequently, downloads fail with a “network error”.

Proposed fix (to apply to Colab contexts only): When a run is selected
from the “run to download” dropdown menu, instead of updating the href
property of the links, send off two asynchronous fetch requests: one
to the CSV data and one to the JSON data. As these resolve, update the
hrefs to point to data URLs/blob URLs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.