tensorflow / tensorflow/tensorboard
Scalar plugin download links should work in Colab
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 7.2k
- Forks
- 1.7k
- Avg merge
- 4d 22h
- Merged PRs (30d)
- 1
Description
Currently, the scalar plugin download links use <a href download>,
where the href points to a route on the TensorBoard backend. This
works fine locally, but on Colab requests to the backend are mediated by
a service worker, and the service worker does not appear to intercept
these requests. Consequently, downloads fail with a “network error”.
Proposed fix (to apply to Colab contexts only): When a run is selected
from the “run to download” dropdown menu, instead of updating the href
property of the links, send off two asynchronous fetch requests: one
to the CSV data and one to the JSON data. As these resolve, update the
hrefs to point to data URLs/blob URLs.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.