tensorflow / tensorflow/tensorboard

Deduplicate vz-line-chart and vz-line-chart2

Open
#1,700 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

core:frontend type:cleanup
Dominant language
TypeScript
Stars
7.2k
Forks
1.7k
Avg merge
4d 22h
Merged PRs (30d)
1

Description

There is a lot of code that has been copy-pasted between these modules.
This can easily lead to skew: PRs like #1698 that want to change part of
the common code need to remember to change both implementations.

Let us please figure out why VZLC2 was forked and how we can reintegrate
the two. This is a significant piece of technical debt.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by comparing the vz-line-chart and vz-line-chart2 modules and reviewing PR #1698 to understand why the second implementation was forked. Determine a viable way to reintegrate their shared code, with completion marked by removing the duplicated implementation differences without changing required chart behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization, frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.