tensorflow / tensorflow/tensorboard

[Projector] Label by should appear even if no color map options are available.

Open
#1,256 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

plugin:projector stat:contributions welcome type:feature
Dominant language
TypeScript
Stars
7.2k
Forks
1.7k
Avg merge
4d 22h
Merged PRs (30d)
1

Description

  • TensorBoard and TensorFlow version 1.8
  • OS Platform and version (Linux Ubuntu 17.10)
  • Python version (2.7.14)
  • Browser: Safari version 11.1.1 (13605.2.8)

schermata 2018-06-17 alle 12 26 41

If no metadata column meets the conditions to be used as a colormap (ie it has less than 50 unique values, or it is numeric), the section with label by and color by does not appear in the Tensorboard projector interface.

 <div hidden$="[[!_hasChoices(colorOptions)]]">
    <div class="colorlabel-container">
      <!-- Label by -->
      <paper-dropdown-menu id="labelby" no-animations label="Label by">
        <paper-listbox attr-for-selected="value" class="dropdown-content" selected="{{selectedLabelOption}}" slot="dropdown-content">
          <template is="dom-repeat" items="[[labelOptions]]">
            <paper-item value="[[item]]" label="[[item]]">
              [[item]]
            </paper-item>
          </template>
        </paper-listbox>
      </paper-dropdown-menu>
      <!-- Color by -->
      <paper-dropdown-menu id="colorby" no-animations label="Color by">
        <paper-listbox attr-for-selected="value" class="dropdown-content" selected="{{selectedColorOptionName}}" slot="dropdown-content">
          <template is="dom-repeat" items="[[colorOptions]]">
            <paper-item class$="[[getSeparatorClass(item.isSeparator)]]" value="[[item.name]]" label="[[item.name]]" disabled="[[item.isSeparator]]">
              [[item.name]]
              <span class="item-details">[[item.desc]]</span>
            </paper-item>
          </template>
        </paper-listbox>
      </paper-dropdown-menu>
    </div>

Despite this, there could be interesting columns to show as a label in the metadata.
From an interface point of view would not it be better to show both options anyway with the message 'No colormap'?

schermata 2018-06-17 alle 12 37 40

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in the TensorBoard Projector interface at the markup containing hidden$="[[!_hasChoices(colorOptions)]]" and the Label by/Color by dropdowns. Inspect how labelOptions and colorOptions are populated when no colormap is available, then verify that Label by remains visible and Color by communicates that no colormap is available.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.