tensorflow / tensorflow/tensorboard

Excess right-padding when displaying expanded nodes in graph view

Open
#1,058 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

plugin:graph
Dominant language
TypeScript
Stars
7.2k
Forks
1.7k
Avg merge
4d 22h
Merged PRs (30d)
1

Description

When displaying expanded nodes in a Tensorboard graph, a large amount of empty space is generated on the right side of node. The name is centered in the expanded node, but sub-nodes are positioned off to the left, suggesting a miscalculation of the space required to display the sub-nodes without clipping or excess right-padding (possibly to allocate space for something that isn't required?).

For operations connected in series, the excess space is about 2/3 of the total space, and the issue becomes more pronounced/significant the more nested layers are expanded. Issue occurs across both Chrome and Firefox.

Simple graph consisting of a single conv2d node.
simple_graph

The highest-level node of a more complex graph with multiple branches in parallel.
high_level

The same graph as above when the branches are expanded. Most of the display space is wasted on excess padding as the issue occurs with each expanded node. Note that the excess space used is the same between the top-level node and the lower-level nodes, implying a constant excess rather than one proportional to the size of rest of the node.
expanded

Setup details:

  • TensorBoard/TensorFlow version = 1.6.0
  • OS Platform and version = Windows 10
  • Python version = 3.6.4
  • Browser type and version = Chrome 64.0.3282.186/Firefox 59.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Reproduce the expanded-node layout with the simple conv2d graph in TensorBoard's graph view using Chrome or Firefox, then trace the layout calculation for nested nodes. Done means expanded nodes no longer reserve excessive right-padding or clip their sub-nodes, including the nested and branched examples.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
data-visualization
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.