tensorflow / tensorflow/probability

Misleading comment in BNN code

Open
#732 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
4.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Looking at the comment in the BNN example, it says that the architecture is "LeNet-5" ... but when I looked at LeNet paper and various articles, the second convolutional layer in Lenet-5 is mapped a little differently than in a simple CNN (like in your code) ...

Might be a good idea to change the comment or mention this as a side note ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at tensorflow_probability/examples/bayesian_neural_network.py#L17 and compare the comment's description with the linked LeNet paper and references. Update the comment or add a side note so the example's architecture is described accurately.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, tensorflow
Domain
documentation, machine-learning
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.