tensorflow / tensorflow/probability

Why inverse log determinant jacobian will be broadcastrd in tfd.TransformedDistribution?

Open
#576 1 comment 0 reactions 2 assignees View on GitHub

@jvdillon is already working on this.

Since Sep 30, 2019.

Dominant language
Jupyter Notebook
Stars
4.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

In previous, I Implemented Glow in this library. #545
But my training, range of loss is too large.

I try these code. https://colab.research.google.com/gist/MokkeMeguru/650a3cc41769ae8fab9be73f9826644f/matveclu.ipynb

I notice ildj is broadcasted in tfd.TransformedDistribution.log_prob.

I think there are two problems.

  1. Blockwise Bijector is invalid implementation.
    folding batch_size is unexpected

  2. tfd.TransfromedDistribution._finish_log_prob_for_one_fiber needs some assertion
    I don't think ildj can be broadcast.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.