tensorflow / tensorflow/probability

Can't set name of real_nvp_default_template variables

Open
#485 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
4.4k
Forks
1.1k
PR merge metrics
No merged PRs in 30d

Description

Passing a name to real_nvp_default_template doesn't affect the final variable name. This is because make_template uses a hardcoded name (line 305).

Example:

import tensorflow as tf
import tensorflow_probability as tfp
tfb = tfp.bijectors
bij = tfb.RealNVP(10, shift_and_log_scale_fn =
    tfb.real_nvp_default_template((5,), activation=tf.nn.relu, name='foo'))
bij.forward(tf.zeros(20)) # Creates variables
tf.trainable_variables()

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at make_template around line 305, as identified in the issue, and trace how the name passed to real_nvp_default_template reaches variable creation. Reproduce the provided RealNVP example and confirm that the resulting trainable variables use the supplied name rather than the hardcoded one.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, tensorflow
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.